Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RadioButtonGetsResetAfterSubmittingEnhancedForm #60920

Merged
merged 2 commits into from
Mar 17, 2025
+2 −3
Merged

Fix RadioButtonGetsResetAfterSubmittingEnhancedForm #60920

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52483a8
Remove quaranteene and make the assert wait a bit.
ilonatommy Mar 13, 2025
47e1a16
Feedback.
ilonatommy Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Feedback.
@ilonatommy
ilonatommy committed Mar 14, 2025
commit 47e1a167c38736f635aa7b5088048944062cb3a7
5 changes: 2 additions & 3 deletions ...s/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs
View file
Original file line number Diff line number Diff line change
@@ -1377,9 +1377,8 @@ public void RadioButtonGetsResetAfterSubmittingEnhancedForm()

Browser.Exists(By.Id("submit-button")).Click();

var timeout = TimeSpan.FromSeconds(1);
WaitAssert.False(Browser, () => Browser.Exists(By.Id("checkbox")).Selected, timeout);
WaitAssert.False(Browser, () => Browser.Exists(By.Id("radio-button")).Selected, timeout);
WaitAssert.False(Browser, () => Browser.Exists(By.Id("checkbox")).Selected);
WaitAssert.False(Browser, () => Browser.Exists(By.Id("radio-button")).Selected);
}

[Fact]
3 changes: 0 additions & 3 deletions src/Shared/E2ETesting/WaitAssert.cs
View file
Original file line number Diff line number Diff line change
@@ -41,9 +41,6 @@ public static void True(this IWebDriver driver, Func<bool> actual, TimeSpan time
public static void False(this IWebDriver driver, Func<bool> actual)
=> WaitAssertCore(driver, () => Assert.False(actual()));

public static void False(this IWebDriver driver, Func<bool> actual, TimeSpan timeout)
=> WaitAssertCore(driver, () => Assert.False(actual()), timeout);

public static void Contains(this IWebDriver driver, string expectedSubstring, Func<string> actualString)
=> WaitAssertCore(driver, () => Assert.Contains(expectedSubstring, actualString()));