-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable static code analysis pilot in pipeline #60743
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request enables a static code analysis pilot within the CI pipeline by adding new configuration flags.
- Enables a new policy ("MicrosoftCanary")
- Activates the prefast analysis with break enabled and sets its severity to CriticalError
- Sets new feature flags for prefast versioning and enablement check
Reviewed Changes
File | Description |
---|---|
.azure/pipelines/ci.yml | New static code analysis settings added to the pipeline configuration |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.azure/pipelines/ci.yml:131
- Verify that 'CriticalError' is an accepted value for severity. Some systems expect severity levels in a specific format, such as lowercase.
severity: CriticalError
.azure/pipelines/ci.yml:134
- [nitpick] Consider renaming 'checkIfEnablePrefast' to a more concise flag, such as 'enablePrefastCheck', to improve clarity and maintain consistency with similar flag naming.
checkIfEnablePrefast: false
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
Internal build failed - working w/ the static analysis team to figure out a fix |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Turn on static code analysis feature in SDL