Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 7, 2024

Backport of #59352 to release/9.0

/cc @BrennanConroy

Fix Kestrel host header mismatch handling when port in Url

Description

Fixes some validation of host headers in Kestrel if a non-default port is included in the request url.

Customer Impact

Valid requests will result in a 400 error response if they hit this case.
An internal partner team is hitting this currently.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Small bug fix with additional unit test coverage to make sure it works and doesn't regress in the future.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Dec 7, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Dec 7, 2024
@BrennanConroy BrennanConroy added Servicing-consider Shiproom approval is required for the issue Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Dec 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 17, 2024
@wtgodbe wtgodbe merged commit c7529f9 into release/9.0 Jan 8, 2025
25 checks passed
@wtgodbe wtgodbe deleted the backport/pr-59352-to-release/9.0 branch January 8, 2025 00:01
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 9.0.x, 9.0.2 Jan 8, 2025
@renovate renovate bot mentioned this pull request Mar 19, 2025
1 task
This was referenced Nov 6, 2025
This was referenced Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants