[Infrastructure] Update Selenium versions #59268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiercn
commented
Dec 2, 2024
javiercn
commented
- Updates Selenium versions to 4.27.0
- Updates Docker image to 131.0
ghost
added
the
area-infrastructure
javiercn
commented
Dec 2, 2024
| WORKDIR /app | ||
|
|
||
| FROM mcr.microsoft.com/playwright/dotnet:v1.45.1-jammy-amd64 AS final | ||
| FROM docker pull mcr.microsoft.com/playwright/dotnet:v1.46.0-noble AS final |
Member
Author
There was a problem hiding this comment.
@MackinnonBuck you updated this like 5 months ago.
Is it fair that we need to grab the latest version from https://hub.docker.com/r/microsoft/playwright-dotnet?
Member
There was a problem hiding this comment.
The version of the docker image needs to exactly match the version in Versions.props. Otherwise, the benchmarks will fail to run. So if we make this change, we should also update the Playwright dependency for the rest of the repo.
Member
Author
There was a problem hiding this comment.
Thanks!
Is there a way this type of thing can be caught during the build? In CI i mean
Update Playwright version in Versions.props
javiercn
commented
Dec 3, 2024
maraf
approved these changes
Dec 5, 2024
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
* [Infrastructure] Update Selenium versions * Update Versions.props Update Playwright version in Versions.props * Update dockerfile * Update eng/Versions.props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.