Hot Reload agent improvements #58333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tmat
force-pushed
the
AgentRefactoring
branch
from
e97d1e9 to
14f9a5e
Compare
tmat
commented
Oct 10, 2024
tmat
force-pushed
the
AgentRefactoring
branch
from
baf0f45 to
150d45e
Compare
Refactor agent code so that it can be shared with dotnet-watch implementation via a shared project. Add new API applyHotReloadDeltas to apply updates.
tmat
force-pushed
the
AgentRefactoring
branch
from
150d45e to
f791377
Compare
tmat
commented
Nov 15, 2024
src/Components/WebAssembly/WebAssembly/src/HotReload/MetadataUpdateHandlerInvoker.cs
Show resolved
Hide resolved
tmat
commented
Nov 15, 2024
|
@MackinnonBuck @javiercn |
|
@tmat I don't have a lot of context on how this works at a low level, but the changes seem reasonable (I did not spot anything wrong). I saw there was a test file that was removed, are we maintaining the coverage that we had or have the tests become obsolete (or moved somewhere else). |
MackinnonBuck
approved these changes
Nov 18, 2024
src/Components/WebAssembly/WebAssembly/src/HotReload/HotReloadAgent.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly/src/HotReload/HotReloadAgent.cs
Outdated
Show resolved
Hide resolved
|
@wtgodbe the modifications to |
This was referenced Jan 15, 2025
tmat
added a commit
to tmat/AspNetCore
that referenced
this pull request
Jan 25, 2025
* Hot Reload agent improvements Refactor agent code so that it can be shared with dotnet-watch implementation via a shared project. Add new API applyHotReloadDeltas to apply updates. * Feedback and cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor agent code so that it can be shared with dotnet-watch implementation via a shared project.
Add new API
applyHotReloadDeltasto apply updates. This API takes a set of deltas and returns log entries reported so far by the client.