Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for sentinel value when setting HTTP/3 error code #57976

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Check for sentinel value when setting HTTP/3 error code #57976

merged 1 commit into from
Sep 20, 2024

Commits on Sep 19, 2024

  1. Check for sentinel value when setting HTTP/3 error code 

    If no error code has been set, `IProtocolErrorFeature.Error` will be `-1`.  If we pass that through verbatim, it will be caught by validation in the setter (ironically, of the same property on the same feature object), resulting in an exception and a Critical (but apparently benign) log message.

Fixes dotnet#57933
    @amcasey
    amcasey committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b30eee2 View commit details
    Browse the repository at this point in the history