Skip to content

Conversation

@adityamandaleeka
Copy link
Member

@adityamandaleeka adityamandaleeka commented Aug 7, 2024

Optionally respect HTTP/1.0 Keep-Alive for HTTP.sys

#56558 was done in 9.0 and made it so we respect keep-alives from 1.0 clients in HTTP.sys. This effectively backports that logic to 6.0 but in an opt-in way (behind an AppContext switch).

Description

This change adds an AppContext switch that, when enabled (it's off by default), will allow our HTTP.sys server to respect HTTP/1.0 clients' Connection: Keep-Alive header.

Fixes #56223

Customer Impact

With this change, servers that serve HTTP/1.0 clients can opt in to respecting the keep-alive header, and thereby save on the fixed costs of connection set up/teardown. For situations where there is a significant amount of 1.0 traffic, this can lead to significant cost savings.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

This behavior is opt-in behind an AppContext switch.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@adityamandaleeka adityamandaleeka added the * NO MERGE * Do not merge this PR as long as this label is present. label Aug 7, 2024
@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Aug 7, 2024
@adityamandaleeka adityamandaleeka added this to the 6.0.x milestone Aug 7, 2024
@adityamandaleeka adityamandaleeka added Servicing-consider Shiproom approval is required for the issue and removed * NO MERGE * Do not merge this PR as long as this label is present. labels Aug 8, 2024
@adityamandaleeka adityamandaleeka added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Aug 10, 2024
@wtgodbe wtgodbe merged commit ab8d30d into dotnet:release/6.0 Aug 12, 2024
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 6.0.x, 6.0.34 Aug 12, 2024
@rbhanda rbhanda modified the milestones: 6.0.34, 6.0.35 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants