-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton #54608
Conversation
@@ -18,21 +18,21 @@ public void Run() | |||
// Note: This test produces *a lot* of debug output to aid when debugging failures. The only output | |||
// that is necessary for the functioning of this test is the "Test passed" at the end of this method. | |||
|
|||
Console.WriteLine($"Current directory: {Environment.CurrentDirectory}"); | |||
Console.WriteLine($"Current assembly: {typeof(Program).Assembly.Location}"); | |||
Console.WriteLine($"[{DateTime.Now.ToLongTimeString()}] Current directory: {Environment.CurrentDirectory}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these DateTime.Now's are so that each line within the log has the actual time it was generated. Otherwise all the lines get written out to the xUnit log at the same time and thus all have the same timestamp, which isn't useful if you're trying to see how long it took between lines.
} | ||
|
||
const int MaxWaitTimes = 30; | ||
const int WaitTimeInMS = 250; | ||
const int WaitTimeInMS = 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increase delay time for this retry to hopefully help improve success rate.
await photinoProcess.WaitForExitAsync().TimeoutAfter(TimeSpan.FromSeconds(30)); | ||
await photinoProcess.WaitForExitAsync().TimeoutAfter(TimeSpan.FromSeconds(60)); | ||
|
||
output.WriteLine(testProgramOutput); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always log the test output even on successful runs to help compare successful runs to failed runs (in case it turns out to be a machine slowness issue).
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@wtgodbe can you please merge this test-only change? |
Branches are closed now, we have to wait until they open at the beginning of April (even if the change is test-only, any new commits will trigger new dependency flow, which will disrupt the in-process servicing build) |
/backport to main |
Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/8560378502 |
@BrennanConroy backporting to main failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton
Using index info to reconstruct a base tree...
M src/Components/WebView/test/E2ETest/WebViewManagerE2ETests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Components/WebView/test/E2ETest/WebViewManagerE2ETests.cs
CONFLICT (content): Merge conflict in src/Components/WebView/test/E2ETest/WebViewManagerE2ETests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@BrennanConroy an error occurred while backporting to main, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
@Eilon please make sure this gets to main, or approve the quarantine PR and leave the issue open for someone to investigate. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.AspNetCore.Authentication.JwtBearer](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.AspNetCore.Authentication.JwtBearer/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.AspNetCore.Authentication.JwtBearer/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.AspNetCore.Authentication.JwtBearer/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.AspNetCore.Authentication.JwtBearer/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.Mvc.NewtonsoftJson](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.AspNetCore.Mvc.NewtonsoftJson/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.AspNetCore.Mvc.NewtonsoftJson/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.AspNetCore.Mvc.NewtonsoftJson/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.AspNetCore.Mvc.NewtonsoftJson/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.OpenApi](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.AspNetCore.OpenApi/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.AspNetCore.OpenApi/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.AspNetCore.OpenApi/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.AspNetCore.OpenApi/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.EntityFrameworkCore.Relational](https://docs.microsoft.com/ef/core/) ([source](https://github.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.EntityFrameworkCore.Relational/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.EntityFrameworkCore.Relational/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.EntityFrameworkCore.Relational/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.EntityFrameworkCore.Relational/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.EntityFrameworkCore.Tools](https://docs.microsoft.com/ef/core/) ([source](https://github.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.EntityFrameworkCore.Tools/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.EntityFrameworkCore.Tools/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.EntityFrameworkCore.Tools/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.EntityFrameworkCore.Tools/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.Extensions.Caching.StackExchangeRedis](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.Extensions.Caching.StackExchangeRedis/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.Extensions.Caching.StackExchangeRedis/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.Extensions.Caching.StackExchangeRedis/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.Extensions.Caching.StackExchangeRedis/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.Extensions.Http.Polly](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.Extensions.Http.Polly/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.Extensions.Http.Polly/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.Extensions.Http.Polly/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.Extensions.Http.Polly/8.0.4/8.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dotnet/aspnetcore (Microsoft.AspNetCore.Authentication.JwtBearer)</summary> ### [`v8.0.5`](https://github.com/dotnet/aspnetcore/releases/tag/v8.0.5): .NET 8.0.5 [Release](https://github.com/dotnet/core/releases/tag/v8.0.5) ##### What's Changed - \[release/8.0] Update dependencies from dotnet/source-build-externals by [@​dotnet-maestro](https://github.com/dotnet-maestro) in [dotnet/aspnetcore#54744 - Update branding to 8.0.5 by [@​vseanreesermsft](https://github.com/vseanreesermsft) in [dotnet/aspnetcore#54907 - \[release/8.0] Convert to 1ES templates by [@​RussKie](https://github.com/RussKie) in [dotnet/aspnetcore#54660 - Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton by [@​Eilon](https://github.com/Eilon) in [dotnet/aspnetcore#54608 - \[release/8.0] (deps): Bump src/submodules/googletest from `31993df` to `77afe8e` by [@​dependabot](https://github.com/dependabot) in [dotnet/aspnetcore#54872 - \[release/8.0] Reduce helix-matrix timeout to 5 hours by [@​github-actions](https://github.com/github-actions) in [dotnet/aspnetcore#54778 - \[release/8.0] Preserve RemoteAuthenticationContext during trimming if used in JS interop by [@​halter73](https://github.com/halter73) in [dotnet/aspnetcore#54655 - \[release/8.0] Improve usage of `Type.GetType` when activating types in data protection by [@​github-actions](https://github.com/github-actions) in [dotnet/aspnetcore#54762 - \[release/8.0] Fix route analyzer performance with highly concatenated strings by [@​github-actions](https://github.com/github-actions) in [dotnet/aspnetcore#54763 - \[release/8.0] Suppress .ps1 SDL errors by [@​wtgodbe](https://github.com/wtgodbe) in [dotnet/aspnetcore#54915 - \[release/8.0] Backport test fixes by [@​MackinnonBuck](https://github.com/MackinnonBuck) in [dotnet/aspnetcore#54912 - \[release/8.0] Skip SpotBugs for now by [@​wtgodbe](https://github.com/wtgodbe) in [dotnet/aspnetcore#54952 - Merging internal commits for release/8.0 by [@​vseanreesermsft](https://github.com/vseanreesermsft) in [dotnet/aspnetcore#55034 - \[release/8.0] Update dependencies from dotnet/arcade by [@​dotnet-maestro](https://github.com/dotnet-maestro) in [dotnet/aspnetcore#55061 - \[release/8.0] Update Wix version by [@​github-actions](https://github.com/github-actions) in [dotnet/aspnetcore#55101 **Full Changelog**: dotnet/aspnetcore@v8.0.4...v8.0.5 </details> <details> <summary>dotnet/efcore (Microsoft.EntityFrameworkCore.Relational)</summary> ### [`v8.0.5`](https://github.com/dotnet/efcore/releases/tag/v8.0.5): EF Core 8.0.5 This is a [patch release of EF Core 8.0](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore/8.0.5) containing only updates to dependencies. There are no additional fixes in this release beyond those already shipped in EF Core 8.0.4. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 7am on Sunday,before 7am on Wednesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/digdir/dialogporten). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ole Jørgen Skogstad <[email protected]>
Really not sure what's causing the failure, especially because it fails so rarely. It seems unlikely it's a product bug (in Blazor code), so it seems more likely it's a problem with either the test infrastructure (e.g. slow machines?), or something to do with WebView2.
So if this passes on CI, then I suggest we merge this change and see what happens. And if it fails again in the future then we try additional things, such as a full retry within the test (e.g. if certain parts fail to even load, retry the whole test from scratch).
Fixes #54017