Skip to content

update IdentityModel to latest#54601

Merged
wtgodbe merged 1 commit into
dotnet:darc-main-ca4ef338-88c4-4e46-bd0e-a5b674bc5e69from
jennyf19:jennyf/IdModel7.4.1-1
Apr 2, 2024
Merged

update IdentityModel to latest#54601
wtgodbe merged 1 commit into
dotnet:darc-main-ca4ef338-88c4-4e46-bd0e-a5b674bc5e69from
jennyf19:jennyf/IdModel7.4.1-1

Conversation

@jennyf19

Copy link
Copy Markdown
Contributor

Update Microsoft.IdentityModel to latest 7.4.1

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

7.4.1 includes this fix: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2412 as well as several other bugs and perf improvements since 7.1.2. Release notes for details

@jennyf19 jennyf19 requested review from a team and wtgodbe as code owners March 18, 2024 15:41
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 18, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Mar 18, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Thanks for your PR, @jennyf19. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mkArtakMSFT

Copy link
Copy Markdown
Contributor

@jennyf19 are there any breaking changes in this release? If not, I wonder if this is something we should try to port to 8?
@halter73 what do you think?

@wtgodbe

wtgodbe commented Mar 18, 2024

Copy link
Copy Markdown
Member

We need a corresponding source-build-externals update before taking this

@jennyf19

Copy link
Copy Markdown
Contributor Author

@jennyf19 are there any breaking changes in this release? If not, I wonder if this is something we should try to port to 8? @halter73 what do you think?

No breaking changes, but a lot of bug fixes.

@jennyf19

Copy link
Copy Markdown
Contributor Author

We need a corresponding source-build-externals update before taking this

Yes, thanks @wtgodbe ...is that something you can help with?

@wtgodbe

wtgodbe commented Mar 18, 2024

Copy link
Copy Markdown
Member

dotnet/source-build-externals#293 will need to be merged, then we'll need to take an update from source-build-externals

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service Bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 26, 2024
@jennyf19

Copy link
Copy Markdown
Contributor Author

@wtgodbe will this still make it in?

@martincostello

Copy link
Copy Markdown
Member

As latest is now 7.5.0, should there be a further update?

@wtgodbe

wtgodbe commented Apr 1, 2024

Copy link
Copy Markdown
Member

Working on getting dotnet/source-build-externals#293 green now

@wtgodbe

wtgodbe commented Apr 1, 2024

Copy link
Copy Markdown
Member

dotnet/source-build-externals#293 is merged, next dependency flow from that repo should unblock this

@wtgodbe

wtgodbe commented Apr 2, 2024

Copy link
Copy Markdown
Member

#54890 will unblock

@wtgodbe wtgodbe changed the base branch from main to darc-main-ca4ef338-88c4-4e46-bd0e-a5b674bc5e69 April 2, 2024 01:08
@wtgodbe

wtgodbe commented Apr 2, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe wtgodbe merged commit 937ca2a into dotnet:darc-main-ca4ef338-88c4-4e46-bd0e-a5b674bc5e69 Apr 2, 2024
@wtgodbe

wtgodbe commented Apr 2, 2024

Copy link
Copy Markdown
Member

#54890 will update the IdentityModel version when merged into main

@wtgodbe

wtgodbe commented Apr 2, 2024

Copy link
Copy Markdown
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants