[release/6.0] [Blazor] Fix duplicated place holder in log message

[gayaK]

Fix duplicated place holder in log message

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Fix bug of log message in .NET6 or earlyer.

Description

Microsoft.AspNetCore.Components.RenderTree.Renderer+Log.InitializingChildComponent() has duplicated place holder ParentComponentId.

However, .NET7 or later are already fixed by #35585

Customer Impact

This PR can avoid frequent exceptions on some logging frameworks.

• serilog
• nlog

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

The logic has not been modified, only the message has been modified.

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

---

When servicing release/2.1

• Make necessary changes in eng/PatchConfig.props

[ghost]

Thanks for your PR, @gayaK. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[ghost]

Hi @gayaK. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[mkArtakMSFT]

Thanks @gayaK.
Is this actually something that impacts you and if so can you share more details about your scenario?
Servicing pretty much anything has an inherent risk to it that we'd rather avoid.

[gayaK]

Thank you for reviewing and approving my PR.

This update resolves a bug that leads to decreased performance under specific circumstances:

• When utilizing Blazor on .NET 6
• When using specific logging frameworks (such as NLog)
• When debug-level logging is enabled
• During the initialization of nested Blazor components every time

I believe the benefits outweigh the risks, considering that debug-level logging is seldom enabled in production environments.

Details

The unfixed message in Microsoft.AspNetCore.Components.RenderTree.Renderer will be transformed into FormattedLogValues, containing the following key-value pairs:

Key	Value Type	Correct Key
ComponentId	int	ComponentId
ComponentType	type	ComponentType
ParentComponentId	int	ParentComponentId
ParentComponentId	type	ParentComponentType

Nevertheless, some of these frameworks convert the list into a dictionary, leading to exceptions caused by duplicated keys.

The following is a part of the stack trace that causes the exception in NLog.

1. NLog.Extensions.Logging.NLogLogger.CreateLogEventInfo‎
2. NLog.LogEventInfo.ctor
3. NLog.Internal.PropertiesDictionary.InsertMessagePropertiesIntoEmptyDictionary

After catching that exception, key-value pairs are converted to the following:

Key	Value Type
ComponentId	int
ComponentType	type
ParentComponentId	int
ParentComponentId_1	type

I also intend to report this issue to NLog.

[ghost]

Hi @gayaK. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

[ghost]

Hi @gayaK. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

[mkArtakMSFT]

Thank you for your contribution, @gayaK!