[Blazor] Fix WebView renderer not correctly dispatching browser events #49958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
approved these changes
Aug 9, 2023
|
@captainsafia Hopefully, all cases that fallback to a renderer ID of 0 have been eliminated. I've scanned the source for remaining cases, but it looks like they should all be addressed now. The root of the problem was that for one method, |
Eilon
approved these changes
Aug 9, 2023
ghost
added this to the 
campersau
reviewed
Aug 9, 2023
| @@ -24,7 +24,7 @@ export function attachRootComponentToLogicalElement(browserRendererId: number, l | |||
| browserRenderer.attachRootComponentToLogicalElement(componentId, logicalElement, appendContent); | |||
| } | |||
|
|
|||
| export function attachRootComponentToElement(elementSelector: string, componentId: number, browserRendererId?: number): void { | |||
| export function attachRootComponentToElement(elementSelector: string, componentId: number, browserRendererId: number): void { | |||
There was a problem hiding this comment.
Since browserRenderId is now required could the fallback to 0 in line 47 be removed?
browserRendererId || 0
There was a problem hiding this comment.
Yeah, it could be. I can remove it the next time I touch this area, but feel free to open a PR if you feel inclined :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix WebView renderer not correctly dispatching browser events
Fixes an issue where Blazor Hybrid throws an exception when a browser event gets emitted. This results in console errors upon user interaction.
Fixes dotnet/maui/issues/16609