Add WebApplication.CreateEmptyBuilder #49246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Allow an empty WebApplicationBuilder to be created without default behavior. There is no default configuration sources (ex. environment variables or appsettings.json files), no logging, and no web server (ex. Kestrel) configured by default. These can all be added explicitly by the app. The following middleware can be enabled by the app: - Routing and Endpoints, if the app calls MapXXX or registers an EndpointDataSource manually - AuthN/Z, if the app adds the corresponding Auth services - HostFiltering and ForwardedHeaders Fix dotnet#48811
eerhardt
force-pushed
the
EmptyWebApplication
branch
from
933bdee to
5cf2861
Compare
davidfowl
reviewed
Jul 6, 2023
src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs
Outdated
Show resolved
Hide resolved
mitchdenny
reviewed
Jul 10, 2023
Remove Routing from the "Empty" builder. It is up to the app to configure what they want. This is the Empty WebApplication.
mitchdenny
approved these changes
Jul 12, 2023
halter73
approved these changes
Jul 12, 2023
| _genericWebHostServiceDescriptor = InitializeHosting(bootstrapHostBuilder); | ||
| } | ||
|
|
||
| internal WebApplicationBuilder(WebApplicationOptions options, bool slim, bool empty, Action<IHostBuilder>? configureDefaults = null) |
There was a problem hiding this comment.
Nit: We only have two remaining readonly fields. Is it time to make those non readonly (and possibly "lie" about the nullability), give these more logical method names and remove the weird bool args. E.g. InitializeEmpty, InitializeSlim, InitializeFull?
There was a problem hiding this comment.
Let's consider this in a future change. I'm not excited about the factoring now, but it can easily be changed later without breaking anyone.
Respect hosting startup configuration. Refactor to share logic.
amcasey
added
area-networking
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an empty WebApplicationBuilder to be created without default behavior. There is no default configuration sources (ex. environment variables or appsettings.json files), no logging, and no web server (ex. Kestrel) configured by default. These can all be added explicitly by the app.
The following middleware can be enabled by the app:
Fix #48811
cc @DamianEdwards @davidfowl