[release/8.0-preview5] [Blazor] Fix WebView JavaScript boot bug #48594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MackinnonBuck
added
the
Servicing-consider
|
Hi @MackinnonBuck. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
mkArtakMSFT
added
* NO MERGE *
|
Hi @MackinnonBuck. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
|
IMPORTANT: we're still waiting for validation of this fix. @MackinnonBuck when you confirm that this is the right fix, please remove the |
mkArtakMSFT
approved these changes
Jun 2, 2023
MackinnonBuck
removed
the
* NO MERGE *
|
Completed manual verification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Blazor] Fix WebView JavaScript boot bug
Fixes an issue where the WebView IPC receiver starts before the JavaScript dispatcher object gets initialized, preventing all Blazor Hybrid apps from starting.
Description
Due to some recent major changes in this area, a WebView-specific initialization order bug was introduced that prevents Blazor Hybrid apps from booting correctly.
Unblocks dotnet/maui#15415
Customer Impact
Very large. All Blazor Hybrid apps will fail to start without a workaround.
Regression?
Regressed from .NET 8.0 Preview 4
Risk
The fix is very isolated and unlikely to introduce another bug.
Verification
Packaging changes reviewed?