Skip to content

Conversation

@amcasey
Copy link
Member

@amcasey amcasey commented May 8, 2023

Load configuration in UseHttps

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Load configuration in UseHttps so that configuration-based certs will be considered, if necessary.

Largely salvaged from #48056
Builds on #48137
Fixes #45801

@ghost ghost added the area-runtime label May 8, 2023
So that configuration-based certs will be considered, if necessary.

Largely salvaged from dotnet#48056
Builds on dotnet#48137
Fixes dotnet#45801
@amcasey amcasey marked this pull request as ready for review May 12, 2023 19:08
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcasey amcasey merged commit ede4e0b into dotnet:main May 17, 2023
@amcasey amcasey deleted the gh45801eager branch May 17, 2023 18:23
@ghost ghost added this to the 8.0-preview5 milestone May 17, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kestrel config behaves differently when set using env vars vs. in-code

4 participants