Introduce ListenOptions.GetServerCertificate #48054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as a way to retrieve the server certificate eagerly (assuming the configuration has been loaded), rather than having to wait until bind-time. Fixes dotnet#28120
amcasey
requested review from
BrennanConroy,
JamesNK,
Tratcher,
halter73 and
mgravell
as code owners
ghost
added
the
Member
Author
|
Waiting for API approval (and PR approval, obviously). |
mitchdenny
reviewed
May 3, 2023
amcasey
added
the
blocked
Member
|
Is there an API review for this? |
Member
Author
|
| { | ||
| ran1 = true; | ||
| var serverCertificate = listenOptions.GetServerCertificate(); | ||
| Assert.Equal(serverCertificate.SerialNumber, certificate.SerialNumber); |
Member
There was a problem hiding this comment.
Some of the asserts are in the wrong order. It's generally Assert.Something(expected, actual)
Member
Author
There was a problem hiding this comment.
Agreed, but I was following the pattern of the nearby tests.
4 tasks
Tratcher
requested changes
May 3, 2023
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
I think this needs a different design. I've left notes on the API review.
4 tasks
Member
Author
|
We're going to try to fix things without a new API. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce ListenOptions.GetServerCertificate
An API to retrieve the cert for an endpoint
Description
Introduce ListenOptions.GetServerCertificate as a way to retrieve the server certificate eagerly (assuming the configuration has been loaded), rather than having to wait until bind-time.
Fixes #28120
Unblocks #45801