Workaround for ASP.NET composite image per #84860 #47747
Conversation
In our work on enabling composite Docker containers on Linux we hit a problem caused by the fact that the SDK uses and publishes its own version of the managed assembly Microsoft.Extensions.Logging.Abstractions clashing with the version of the assembly in the composite image. As we're doing our best for publishing the Docker container in Preview 4, I propose merging in this simple workaround as a stopgap change; I have created a tracking issues for fixing this cleanly by fixing SDK to start using the version of the assembly from the aspnetcore repo instead of using its own copy. Thanks Tomas
ghost
added
the
area-infrastructure
|
@lbussell - I believe that the aspnetcore repo should run an official build later tonight or tomorrow that should produce an updated nuget with my fix, it would be great if you could give it a shot w.r.t. the docker build script, I'll try to do the same. The time is pretty tight so if there are any remaining problems, it would be great to identify them as soon as possible. |
Sounds good, if the build is coherent I'll give it a shot, otherwise we might have to wait until the dependency flows into installer and @ivdiazsa generates another tarball? |
|
Hi @lbussell. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
@lbussell believe the workaround is within the asp.net repo itself, and it should not cause the mvid mismatch even with build version differences, now that the M.Extensions.Logging assembly has been removed from the composite. So trying with the latest daily asp.net build should be good. |
|
Hi @mangod9. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
@lbussell - I believe the latest official aspnetcore CI build succeeded and produced the tarball aspnetcore-runtime-composite-8.0.0-preview.4.23218.4-linux-x64.tar.gz I have downloaded the file from the official build artifacts and I have double-checked using the R2RDump tool that it indeed no longer includes the problematic assembly |
|
Hi @trylek. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
In our work on enabling composite Docker containers on Linux we hit a problem caused by the fact that the SDK uses and publishes its own version of the managed assembly Microsoft.Extensions.Logging.Abstractions clashing with the version of the assembly in the composite image. As we're doing our best for publishing the Docker container in Preview 4, I propose merging in this simple workaround as a stopgap change; I have created a tracking issues for fixing this cleanly by fixing SDK to start using the version of the assembly from the aspnetcore repo instead of using its own copy. Thanks Tomas
5 participants
In our work on enabling composite Docker containers on Linux we hit a problem caused by the fact that the SDK uses and publishes its own version of the managed assembly
Microsoft.Extensions.Logging.Abstractions
clashing with the version of the assembly in the composite image. As we're doing our best for publishing the Docker container in Preview 4, I propose merging in this simple workaround as a stopgap change; I have created a tracking issue for fixing this cleanly by fixing SDK to start using the version of the assembly from the aspnetcore repo instead of using its own copy.
Thanks
Tomas
/cc @dotnet/crossgen-contrib