Apply MIBC optimization data when building ASP.NET composite #47333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have verified in the ASP.NET perf lab that the combined ASP.NET + framework composite image can achieve better startup perf by about 5% by using the standard MIBC optimization data so I'm proposing to modify the build script to use it. The resulting composite image is larger by about 850 KB (Linux x64 without MIBC = 33,853,952 B, with MIBC = 34,702,336 B) so I believe that thanks to the fact that I recently reduced the composite image size by more than 30 MB we have sufficient headroom to make this change. Thanks Tomas P.S. In some previous meetings I mentioned worse startup perf when using MIBC data for building the composite image; that was due to a self-inflicted wound - at one point I was mostly focusing on reducing size so I modified my perf measurement tool to automatically apply the "--partial" option in the presence of a MIBC file, that apparently turns out to be too drastic in terms of startup perf.
ghost
added
the
area-infrastructure
Member
|
Nice to see a perf gain with mibc. Assume this data is updated regularly> |
mangod9
approved these changes
Mar 20, 2023
Member
Author
|
@mangod9 - According to my understanding of the script the data is pulled from the most recent .NET SDK. Based on @davidwrighton's explanation I believe this is regularly updated based on some bucket of training apps. |
Member
|
@trylek, @mangod9 Yes, we update the data semi-regularly. In theory it should be daily, but the process of gathering data is somewhat unreliable, and I only have so much time in the year to ensure its working. I make sure it is working towards the end of the release cycle, and occasionally I'm able to fix it up at other times. |
davidwrighton
approved these changes
Mar 20, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified in the ASP.NET perf lab that the combined ASP.NET + framework composite image can achieve better startup perf by about 5% by using the standard MIBC optimization data so I'm proposing to modify the build script to use it. The resulting composite image is larger by about 850 KB (Linux x64 without MIBC = 33,853,952 B, with MIBC = 34,702,336 B) so I believe that thanks to the fact that I recently reduced the composite image size by more than 30 MB we have sufficient headroom to make this change.
Thanks
Tomas
P.S. In some previous meetings I mentioned worse startup perf when using MIBC data for building the composite image; that was due to a self-inflicted wound - at one point I was mostly focusing on reducing size so I modified my perf measurement tool to automatically apply the "--partial" option in the presence of a MIBC file, that apparently turns out to be too drastic in terms of startup perf.
/cc @dotnet/crossgen-contrib