Skip to content

Set up TryParse blocks for explicit header parameters. #47017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchdenny merged 1 commit into from
Mar 4, 2023
Merged

Set up TryParse blocks for explicit header parameters. #47017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Http/Http.Extensions/gen/StaticRouteHandlerModel/EndpointParameter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ public EndpointParameter(IParameterSymbol parameter, WellKnownTypes wellKnownTyp
Source = EndpointParameterSource.Header;
Name = GetParameterName(fromHeaderAttribute, parameter.Name);
IsOptional = parameter.IsOptional();
IsParsable = TryGetParsability(parameter, wellKnownTypes, out var parsingBlockEmitter);
ParsingBlockEmitter = parsingBlockEmitter;
}
else if (TryGetExplicitFromJsonBody(parameter, wellKnownTypes, out var isOptional))
{
Expand Down
19 changes: 19 additions & 0 deletions src/Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,25 @@ public async Task MapAction_TryParsableExplicitRouteParameters(string typeName,
Assert.Equal(expectedParameterValue, httpContext.Items["tryParsable"]);
}

[Theory]
[MemberData(nameof(TryParsableParameters))]
public async Task MapAction_TryParsableExplicitHeaderParameters(string typeName, string headerValue, object expectedParameterValue)
{
var (results, compilation) = await RunGeneratorAsync($$"""
app.MapGet("/", (HttpContext context, [FromHeader]{{typeName}} headerValue) =>
{
context.Items["tryParsable"] = headerValue;
});
""");
var endpoint = GetEndpointFromCompilation(compilation);
var httpContext = CreateHttpContext();
httpContext.Request.Headers["headerValue"] = headerValue;

await endpoint.RequestDelegate(httpContext);
Assert.Equal(200, httpContext.Response.StatusCode);
Assert.Equal(expectedParameterValue, httpContext.Items["tryParsable"]);
}

[Theory]
[MemberData(nameof(TryParsableParameters))]
public async Task MapAction_SingleParsable_StringReturn(string typeName, string queryStringInput, object expectedParameterValue)
Expand Down