-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TryParse code gen to use CodeWriter. #46928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
requested review from
Tratcher,
BrennanConroy and
halter73
as code owners
February 28, 2023 10:20
ghost
added
the
area-runtime
label
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshot updates?
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/EndpointParameter.cs
Outdated
Show resolved
Hide resolved
Not necessary in this case. The existing snapshots are correct. If we merge this then I'll rebase my other PR on it and it probably won't need snapshot updates either ;) |
5 tasks
captainsafia
approved these changes
Mar 1, 2023
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…arameter.cs Co-authored-by: Safia Abdalla <[email protected]>
mitchdenny
force-pushed
the
rdg-tryparse-code-writer
branch
from
March 3, 2023 00:19
cad3282
to
09046e6
Compare
5 tasks
ghost
added this to the 8.0-preview3 milestone
Mar 3, 2023
amcasey
added
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
and removed
area-runtime
labels
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the TryParse block emitter to use code writer. Effectively changing the ParsingBlockEmitter from
Func<string,string,string>
toAction<CodeWriter,string,string>
.