Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logout success log message (Blazor WebAssembly) #45847

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

mmacy
Copy link
Contributor

@mmacy mmacy commented Jan 3, 2023

Correct the logout log message in Blazor WASM to read "logout" instead of "login"

Modifies /src/Components/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.Log.cs to correct the log message and event name on successful logout.

Description

Modifies the attribute decorating the LogoutCompletedSuccessfully method in RemoteAuthenticatorViewCore.Log.cs to refer to logout, not login.

Head:

[LoggerMessage(10, LogLevel.Debug, "Login completed successfully.", EventName = nameof(LoginCompletedSuccessfully))]
public static partial void LogoutCompletedSuccessfully(ILogger logger);

This PR:

[LoggerMessage(10, LogLevel.Debug, "Logout completed successfully.", EventName = nameof(LogoutCompletedSuccessfully))]
public static partial void LogoutCompletedSuccessfully(ILogger logger);

Fixes #45846

@ghost ghost added area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member labels Jan 3, 2023
@ghost
Copy link

ghost commented Jan 3, 2023

Thanks for your PR, @mmacy. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mmacy mmacy marked this pull request as ready for review January 3, 2023 16:33
@mmacy mmacy requested a review from a team as a code owner January 3, 2023 16:33
@TanayParikh
Copy link
Contributor

TanayParikh commented Jan 4, 2023

Looks like you're running into some random CI flakiness, I've re-triggered the tests.

@javiercn javiercn merged commit 9324da0 into dotnet:main Jan 10, 2023
@ghost ghost added this to the 8.0-preview1 milestone Jan 10, 2023
@javiercn
Copy link
Member

@mmacy thanks for the contribution!

@mmacy mmacy deleted the 45846-mmacy-blazorwasm-log-fix branch January 13, 2023 15:54
@mmacy
Copy link
Contributor Author

mmacy commented Jan 13, 2023

@mmacy thanks for the contribution!

My pleasure, @javiercn. 🙂

@ghost
Copy link

ghost commented Jan 13, 2023

Hi @mmacy. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log message on logout success incorrectly states "Login completed successfully." (Blazor WASM)
3 participants