Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blazor][wasm] unify startup bit more #45628

Merged
merged 8 commits into from
Jan 10, 2023
Merged

[blazor][wasm] unify startup bit more #45628

merged 8 commits into from
Jan 10, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 16, 2022 •
edited
Loading

  • update the latest runtime API .d.ts files
  • simplified loader to ES6 only
  • update to usage of setModuleImports
  • connected runtime loader to Blazor cache via downloadResource
  • change to WebAssemblyResourceLoader to return absolute URLs. For debugger purposes.
  • added loading resources from new runtimeAssets collection of blazor.boot.json

@pavelsavara pavelsavara added feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly arch-wasm labels Dec 16, 2022
@pavelsavara pavelsavara added this to the 8.0 milestone Dec 16, 2022
@pavelsavara pavelsavara self-assigned this Dec 16, 2022
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Dec 16, 2022
@pavelsavara pavelsavara mentioned this pull request Dec 16, 2022
Closed
@pavelsavara pavelsavara marked this pull request as ready for review December 19, 2022 19:50
@pavelsavara pavelsavara requested a review from a team as a code owner December 19, 2022 19:50
@build-analysis build-analysis bot mentioned this pull request Jan 3, 2023
Open
5 tasks
@pavelsavara
Copy link
Member Author

Interop.FunctionalTests.HttpClientHttp2InteropTests.Settings_MaxHeaderListSize_Server(scheme: "http") CI failure is unrelated and also on main branch

ilonatommy
ilonatommy approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts Show resolved Hide resolved
@pavelsavara
Copy link
Member Author

@TanayParikh @javiercn @mkArtakMSFT should I wait for your feedback ?

javiercn
javiercn approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @pavelsavara

Thanks for pushing this through!

@pavelsavara pavelsavara merged commit f6a4bc6 into dotnet:main Jan 10, 2023
@ghost ghost modified the milestones: 8.0, 8.0-preview1 Jan 10, 2023
TanayParikh added a commit that referenced this pull request Jan 10, 2023
@TanayParikh
Revert "[blazor][wasm] unify startup bit more (#45628)"
3186f6e 
This reverts commit f6a4bc6.
@TanayParikh TanayParikh mentioned this pull request Jan 10, 2023
Closed
@ilonatommy ilonatommy mentioned this pull request Jan 12, 2023
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@TanayParikh TanayParikh Awaiting requested review from TanayParikh

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @javiercn @ilonatommy