Update static file docs and log if WebRootPath is not found #44296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Oct 1, 2022
Member
Yes. |
Tratcher
force-pushed
the
tratcher/staticfiledocs
branch
from
cd56f51 to
b2e73e6
Compare
JamesNK
approved these changes
Oct 5, 2022
ghost
added this to the
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38481
AspNetCore only serves static files from the wwwroot subfolder by default. This is different from ASP.NET Framework that served from the root directory by default.
Currently there's no warning or error if the wwwroot directory does not exist.
This adds xml docs to clarify the default, and logs warning if the wwwroot directory is missing and you have a StaticFile middleware.