Skip to content

Using WriteJsonAsync<object?> operation for ProblemHttpResult #41670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2022
Merged

Using WriteJsonAsync<object?> operation for ProblemHttpResult #41670

merged 5 commits into from
May 13, 2022

Conversation

@brunolins16
Copy link
Member

@brunolins16 brunolins16 commented May 12, 2022

Fix #41634

@ghost ghost added the area-runtime label May 12, 2022
@brunolins16 brunolins16 requested a review from a team May 12, 2022 21:08
DamianEdwards
DamianEdwards reviewed May 12, 2022
View reviewed changes
halter73
halter73 reviewed May 13, 2022
View reviewed changes
@brunolins16 brunolins16 changed the title Using non-generic JsonWrite operation for ProblemHttpResult Using WriteJsonAsync<object?> operation for ProblemHttpResult May 13, 2022
@brunolins16 brunolins16 merged commit 1230a1a into dotnet:main May 13, 2022
@ghost ghost added this to the 7.0-preview5 milestone May 13, 2022
@brunolins16 brunolins16 deleted the brunolins16/issues/41634 branch August 2, 2022 20:47
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 left review comments

@DamianEdwards DamianEdwards DamianEdwards left review comments

@davidfowl davidfowl davidfowl approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

7.0-preview5

Development

Successfully merging this pull request may close these issues.

Results.ValidationProblem not including errors in response

5 participants

@brunolins16 @halter73 @davidfowl @DamianEdwards @amcasey