Skip to content

Use MIT license for Installer EULA #41286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2022
Merged

Use MIT license for Installer EULA #41286

merged 3 commits into from
Apr 26, 2022

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 20, 2022

Fixes #40835

@wtgodbe wtgodbe requested review from a team and ChrisSfanos April 20, 2022 20:57
@wtgodbe wtgodbe requested a review from Pilchie as a code owner April 20, 2022 20:57
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 20, 2022
@wtgodbe wtgodbe requested a review from joeloff April 20, 2022 21:02
@Pilchie
Copy link
Member

Pilchie commented Apr 20, 2022

Seems fine to me.

@joeloff
Copy link
Member

joeloff commented Apr 20, 2022

That looks like a plain text fail and not RTF. Does it load properly?

@dougbu
Copy link
Contributor

dougbu commented Apr 20, 2022

That looks like a plain text fail and not RTF. Does it load properly?

Whether or not the file is plaintext, I suggest renaming the file to eula.txt and updating its 6 mentions in 2 WXS files.

@dougbu
Copy link
Contributor

dougbu commented Apr 20, 2022

/btw is there a non-GitHub conversation about this❔ I'd like to hear any thoughts @ChrisSfanos has.

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 20, 2022

/btw is there a non-GitHub conversation about this❔ I'd like to hear any thoughts @ChrisSfanos has.

Yep, just forwarded you the email thread

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 20, 2022

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1729658&view=results

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 26, 2022

Test hosting bundle works as expected

@wtgodbe wtgodbe merged commit 4e31ad6 into dotnet:main Apr 26, 2022
@ghost ghost added this to the 7.0-preview5 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisSfanos ChrisSfanos Awaiting requested review from ChrisSfanos

@Pilchie Pilchie Awaiting requested review from Pilchie

@joeloff joeloff Awaiting requested review from joeloff

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

7.0-preview5

Development

Successfully merging this pull request may close these issues.

Windows runtime installer contains .NET Framework EULA

4 participants

@wtgodbe @Pilchie @joeloff @dougbu