Enable a few whitespace enforcing IDE rules #40769
Conversation
ghost
added
the
community-contribution
pranavkm
force-pushed
the
ide200x
branch
4 times, most recently
from
fd41325
to
46f2267
Compare
mkArtakMSFT
added
the
area-infrastructure
|
Whitespace rules? Is this gonna break the build for extra whitespace? |
There are a couple of rules in the repo that already enforce some of these:
This is adding some additional formatting clauses around whitespace that the roslyn repo uses. |
Contributes to dotnet#24055
| # Whitespace options | ||
| csharp_style_allow_embedded_statements_on_same_line_experimental = false | ||
| csharp_style_allow_blank_lines_between_consecutive_braces_experimental = false | ||
| csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = false |
There was a problem hiding this comment.
I don't know if @dotnet/aspdoi has discussed these settings but this particular one is actively annoying and I'd much rather we didn't take it.
| # Whitespace options | ||
| csharp_style_allow_embedded_statements_on_same_line_experimental = false | ||
| csharp_style_allow_blank_lines_between_consecutive_braces_experimental = false | ||
| csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = false |
There was a problem hiding this comment.
In general, we should wait until experimental features have been released for real before incorporating them in this repo. There's no reason to rush here.
I'd go further there and say we're in the weeds here; #24055 was about FxCop, not StyleCop, and certainly not teensy whitespace rules.
Contributes to #24055