Enable IDE0060 #40461
Merged
Enable IDE0060 #40461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
requested review from
BrennanConroy,
halter73,
Tratcher,
javiercn,
a team and
Pilchie
as code owners
Tratcher
approved these changes
Mar 1, 2022
| @@ -28,7 +28,7 @@ public bool IsEnabled(LogLevel logLevel) | |||
| return _provider.IsEnabled; | |||
| } | |||
|
|
|||
| public void Log<TState>(DateTimeOffset timestamp, LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter) | |||
| public void Log<TState>(DateTimeOffset timestamp, LogLevel logLevel, EventId _, TState state, Exception exception, Func<TState, Exception, string> formatter) | |||
There was a problem hiding this comment.
Shouldn't the EventId get logged?
There was a problem hiding this comment.
This method turns the log to a string. We could add it to the log, but I'm not super familiar who the consumer is and if changing the format would affect it in any way.
| @@ -51,7 +50,7 @@ public void Complete() | |||
| } | |||
| } | |||
|
|
|||
| public void Abort(Exception error) | |||
There was a problem hiding this comment.
Should the pipe be completed with this exception?
There was a problem hiding this comment.
- _pipe.Writer.Complete();
+ _pipe.Writer.Complete(error);Like so?
There was a problem hiding this comment.
Yeah, would have to look at the usage to see if we want that though.
Pilchie
added
the
area-infrastructure
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.