-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code gen #40383
Code gen #40383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me (as long as it works 😺).
Curious: How did you decide between the separate TrimmableProject.props option and adding %(TrimmableProject)
metadata in ProjectReferences.props❔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
Out of curiosity, do you have an aspiration to eliminate the component's WASM linking test project? Setting the WASM build properties is simple enough. The more difficult part is distinguishing between trimmable WASM projects and trimmable aspnetcore projects.
Co-authored-by: Doug Bunting <[email protected]>
I followed the pattern for
Right now, this test tests trimmability for all projects in the repo include the WebAssembly ones. I didn't do anything to exclude it since it appears to just work. If we can get some confirmation in the coming ways it doesn't get in the way of doing things, we can remove the WASM specific one. |
Nope. Just wondered about reasonzzz; I have no objections to a separate file, especially because the added information is used in only a couple of places. I'm doing something similar for #40242 and require a separate file because the info I'm adding isn't specific to project reference providers. That didn't apply here. |
@pranavkm This got closed when I merged my PR. Rebase and open a new PR and I'll approve 🙏 |
Follow up from the discussion in #40342