Refactor : Enable CA2249 #40009
Merged
Refactor : Enable CA2249 #40009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Enables CA2249 2. formatted `.editorconfig`
ghost
added
the
community-contribution
ShreyasJejurkar
requested review from
BrennanConroy,
halter73,
javiercn,
Pilchie,
pranavkm and
Tratcher
as code owners
pranavkm
suggested changes
Feb 5, 2022
.editorconfig
Outdated
| @@ -259,52 +262,79 @@ dotnet_diagnostic.IDE2000.severity = warning | |||
| [{eng/tools/**.cs,**/{test,samples,perf}/**.cs}] | |||
| # CA1018: Mark attributes with AttributeUsageAttribute | |||
| dotnet_diagnostic.CA1018.severity = suggestion | |||
|
|
|||
There was a problem hiding this comment.
Could you undo this? The spaces were meant to make comments or description much clearer, but these are all suppressions for tests which don't need that.
.editorconfig
Outdated
| @@ -77,6 +77,9 @@ charset = utf-8-bom | |||
|
|
|||
| [*.{cs,vb}] | |||
|
|
|||
| # CA2249: Use string.Contains instead of string.IndexOf to improve readability. | |||
| dotnet_diagnostic.CA2249.severity = warning | |||
There was a problem hiding this comment.
Can you order it so it appears around line 215 in this file?
mkArtakMSFT
added
area-runtime
area-mvc
mkArtakMSFT
added
area-infrastructure
pranavkm
approved these changes
Feb 5, 2022
|
Thanks, @pranavkm taking care of it. Sorry for the delay from my side. I guess we live in totally opposite timezone, I am in India! But anyway thanks for taking care and merging! |
|
Hi @ShreyasJejurkar. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.editorconfigContributes to #24055