Don't exclude System.IO.Pipelines from TargetingPack version check#39287
Merged
wtgodbe merged 1 commit intodotnet:mainfrom Jan 4, 2022
wtgodbe:wtgodbe/VersionTestingSfx
Merged
Don't exclude System.IO.Pipelines from TargetingPack version check#39287wtgodbe merged 1 commit intodotnet:mainfrom wtgodbe:wtgodbe/VersionTestingSfx
wtgodbe merged 1 commit intodotnet:mainfrom
wtgodbe:wtgodbe/VersionTestingSfx
Conversation
ghost
added
the
area-infrastructure
dougbu
reviewed
Jan 4, 2022
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
If it works, great❕
Does this change imply we no longer have incoming assemblies w/ versions that aren't like 7.0.0.0❔
Member
Author
That's what I saw locally |
Member
Author
|
@dougbu you alright with this change? |
dougbu
approved these changes
Jan 4, 2022
Contributor
Yes, I meant to approve the PR yesterday |
Member
Author
|
/backport to release/6.0 |
Member
Author
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1654775269 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/1654776113 |
This was referenced Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of #31074. Also check that
Version.Build == 0in addition toVersion.Revision