Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trace interfaces from Kestrel transports #37243

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Remove trace interfaces from Kestrel transports #37243

merged 3 commits into from
Oct 6, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 4, 2021 •
edited
Loading

Addresses #31581

The log types could probably be made static. Yay, nay? Made static

halter73
halter73 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of liked having the non-static Trace classes because it felt like it was less likely you'd use the wrong ILogger. But since there's only one ILogger per transport, I don't think it hurts.

Tratcher
Tratcher approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@JamesNK JamesNK enabled auto-merge (squash) October 6, 2021 18:46
@JamesNK JamesNK merged commit b7d2f0e into main Oct 6, 2021
@JamesNK JamesNK deleted the jamesnk/transport-traces branch October 6, 2021 20:11
@ghost ghost added this to the 7.0-preview1 milestone Oct 6, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@Tratcher Tratcher Tratcher approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesNK @halter73 @Tratcher @amcasey