HTTP/3 with IIS #35934
Merged
HTTP/3 with IIS #35934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
wtgodbe
commented
Aug 30, 2021
HaoK
reviewed
Aug 30, 2021
Tratcher
reviewed
Aug 30, 2021
src/Servers/Kestrel/shared/test/TransportTestHelpers/Http3SupportedAttribute.cs
Outdated
Show resolved
Hide resolved
src/Servers/IIS/IIS/test/testassets/InProcessWebSite/Startup.cs
Outdated
Show resolved
Hide resolved
HaoK
reviewed
Aug 30, 2021
| <Project> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" /> | ||
| <PropertyGroup> | ||
| <KestrelSharedSourceRoot>$(MSBuildThisFileDirectory)..\Kestrel\shared\</KestrelSharedSourceRoot> |
Member
There was a problem hiding this comment.
Should we consider moving this to https://github.com/dotnet/aspnetcore/tree/main/src/Shared/Kestrel or something? Is there a reason it needs to be special?
Member
There was a problem hiding this comment.
It's grown very organically, it used to only be shared within Kestrel projects, now it's shared across all the servers. It might be worth moving, but not in this PR. Will, file an issue?
Member
Author
HaoK
reviewed
Sep 1, 2021
| { | ||
| var address = Fixture.Client.BaseAddress.ToString() + "Http3_ResponseTrailers"; | ||
| using var client = SetUpClient(); | ||
| client.DefaultRequestVersion = HttpVersion.Version30; |
Member
There was a problem hiding this comment.
nit: consider passing these in to SetupClient to further streamline the tests
HaoK
approved these changes
Sep 1, 2021
Tratcher
approved these changes
Sep 1, 2021
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1191827654 |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29078
Also moved the
Http3Supportedattribute to kestrel shared test root, next toMSQuicSupportedattribute.