Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kestrel logs to use LoggerMessage #34910

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Update Kestrel logs to use LoggerMessage #34910

merged 1 commit into from
Aug 2, 2021

Conversation

pranavkm
Copy link
Contributor

No description provided.

@ghost ghost added the area-runtime label Jul 31, 2021
JamesNK
JamesNK approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't check the log messages, IDs, and levels closely. If you're confident that nothing has changed then 👍

@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 2, 2021

Nearly all of the messages are verbatim copied by the codefix. The only ones that gave me trouble were the ones that were present as a resx string.

@pranavkm pranavkm merged commit 3027997 into main Aug 2, 2021
@pranavkm pranavkm deleted the prkrishn/kestrel-logs branch August 2, 2021 21:38
@ghost ghost added this to the 6.0-rc1 milestone Aug 2, 2021
@JamesNK JamesNK mentioned this pull request Aug 3, 2021
Closed
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @JamesNK @amcasey