Bump the SDK back up again #33018
Bump the SDK back up again #33018
Conversation
- Publishing.props executes the `_GetPackageVersionInfo` target in Microsoft.AspNetCore.App.Runtime.csproj - that target currently fails when using a new SDK and desktop `msbuild`
- take us back to the 6.0.100-preview.5.21264.3 SDK This reverts commit 57b9c13.
|
PR does a few things but first commit won't matter that much after next CI agent rollout. That said, isolation from desktop |
| public void HasTitle() | ||
| { | ||
| Assert.Equal("E2EPerformance", Browser.Title); | ||
| } | ||
|
|
||
| [Fact] | ||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/32788")] |
There was a problem hiding this comment.
I'm least sure about the changes in this file. @wtgodbe were these quarantined simply due to problems w/ the test app combined w/ the older SDK❔
Mostly wondering: Should we leave these quarantined for 30 days after this gets in i.e. don't un-quarantine as part of this PR❔
There was a problem hiding this comment.
Thoughts on this❔ I feel like I'm violating @BrennanConroy's new process😉
There was a problem hiding this comment.
Our new process. There are always exceptions to the rule, this wasn't flaky before the SDK issues right?
There was a problem hiding this comment.
I'm struggling to remember.
There was a problem hiding this comment.
These should be unquarantined, the flakiness was due to the SDK
|
@dotnet/aspnet-blazor-eng my lower-level questions were mostly for you |
- used in Components.slnf and ComponentsNoDeps.slnf but hidden because it wasn't here
|
Needs #33019 (thx @BrennanConroy) |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Merge when ready. Idk if you want to preserve commits/messages etc. |
Pilchie
added
the
area-infrastructure
ghost
added this to the 
|
YAY! |
Publish in a separate step
_GetPackageVersionInfotarget in Microsoft.AspNetCore.App.Runtime.csprojmsbuildRevert "Revert SDK update (#32785)"
This reverts commit 57b9c13.
Reword a comment