Turn on some CodeAnalysis rules #32837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
requested review from
BrennanConroy,
halter73,
javiercn,
JunTaoLuo,
Pilchie,
Tratcher and
a team
as code owners
Tratcher
reviewed
May 19, 2021
src/HttpClientFactory/Polly/src/HttpRequestMessageExtensions.cs
Outdated
Show resolved
Hide resolved
mkArtakMSFT
added
the
area-infrastructure
pranavkm
force-pushed
the
prkrishn/more-codeanalysis-rules
branch
from
16511e0
to
e89535e
Compare
|
🆙 📅 |
SteveSandersonMS
approved these changes
May 20, 2021
There was a problem hiding this comment.
I've skimmed through this and can't spot anything to get worried about. All looks good!
One aspect that I'm slightly unsure about is removing unused things that seem to relate to external specifications (e.g., the lists of "libs" in UnsafeNativeMethods.cs, or the things in H2SpecCommands.cs). Arguably there's value in representing the full list to avoid confusion about what the missing values are. However since none of that is code that I have a lot of close expertise with, assuming the code owner is happy then I'm sure it's fine!
|
@Tratcher the changes @SteveSandersonMS is talking about are largely in http.sys and IIS's sources. Could you have a look and let me know what your recommendation is? |
Tratcher
approved these changes
May 20, 2021
ghost
added this to the
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
* Turn on some CodeAnalysis rules Commit migrated from dotnet/aspnetcore@af9bb41d623b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #24055
Going thru https://github.com/dotnet/runtime/blob/main/eng/CodeAnalysis.ruleset and adding the ones that have been enabled in that repo.