Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/runtime #32267

Merged
merged 2 commits into from
Apr 30, 2021
Merged

[main] Update dependencies from dotnet/runtime #32267

merged 2 commits into from
Apr 30, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20210429.1
  • Date Produced: 4/29/2021 8:56 AM
  • Commit: 6a5bc5315a6416de33655e127b5fbc5cb97a16a7
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
389014e 
…0429.1

Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Primitives , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.AspNetCore.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Diagnostics.DiagnosticSource , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels
 From Version 6.0.0-preview.5.21227.7 -> To Version 6.0.0-preview.5.21229.1
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner April 29, 2021 12:11
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Apr 29, 2021
ghost
ghost approved these changes Apr 29, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost ghost added the tell-mode Indicates a PR which is being merged during tell-mode label Apr 29, 2021
@wtgodbe
Copy link
Member

wtgodbe commented Apr 29, 2021

/_/src/Components/Components/src/Lifetime/ComponentApplicationState.cs(144,13): Trim analysis error IL2026: Microsoft.AspNetCore.Components.ComponentApplicationState.PersistAsJson(String,TValue): Using method 'System.Text.Json.JsonSerializer.SerializeToUtf8Bytes(TValue,JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.. [D:\workspace_work\1\s\src\Components\WebAssembly\testassets\WasmLinkerTest\WasmLinkerTest.csproj]

@eerhardt I think this is a result of dotnet/runtime#51886 - do we need to make a similar change?

@eerhardt
Copy link
Member

@eerhardt I think this is a result of dotnet/runtime#51886 - do we need to make a similar change?

Yes that is the change that caused it. It looks like we will need to annotate PersistAsJson as RequiresUnreferencedCodeAttribute.

cc @pranavkm

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner April 29, 2021 22:24
@eerhardt
Copy link
Member

FYI - @pranavkm @SteveSandersonMS @captainsafia @javiercn - I pushed a change to this PR to address the new ILLink warnings from annotating System.Text.Json, if you want to take a look.

@dotnet-maestro dotnet-maestro bot merged commit b1c34c8 into main Apr 30, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-4a453fe4-038a-48b1-9b8b-6e28e3529821 branch April 30, 2021 00:09
@ghost ghost added this to the 6.0-preview5 milestone Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode Type: Dependency Update 🔼
Projects
None yet
Milestone
6.0-preview5
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgodbe @eerhardt