-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create subcategories for better filtering Kestrel logs #31596
Create subcategories for better filtering Kestrel logs #31596
Conversation
One failing test:
|
Thanks. |
Oh, i dont know why this test failed
It does not corelated with code changes in this PR. |
The H3 tests are still new and a bit unstable, I've re-run them. |
The same test failed on the second attempt. So it's either really flaky or something changed. I've started a third run to collect more data. |
Never mind. The same test didn't fail. It was ProjectTemplates tests failing on attempt 2 which are very flaky. I was looking at the new ".NET Helix Build Analysis" view. While it's super convenient, it doesn't appear to update on retries. |
} | ||
|
||
public virtual void HeartbeatSlow(TimeSpan heartbeatDuration, TimeSpan interval, DateTimeOffset now) | ||
{ | ||
_heartbeatSlow(_logger, now, heartbeatDuration, interval, null); | ||
_heartbeatSlow(_connectionsLogger, now, heartbeatDuration, interval, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: While the heartbeat does loop over connections, this log is usually an indicator of threadpool starvation.
_heartbeatSlow(_connectionsLogger, now, heartbeatDuration, interval, null); | |
_heartbeatSlow(_generalLogger, now, heartbeatDuration, interval, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great.
…usually an indicator of threadpool starvation
Thanks @fvoronin! (I also accidently put this in the commit message 🤣 ) |
Splitting Kestrel logs into multiple subcategories from general "Microsoft.AspNetCore.Server.Kestrel":
Microsoft.AspNetCore.Server.Kestrel
(current category): ApplicationError, ConnectionHeadResponseBodyWrite, ApplicationNeverCompleted, RequestBodyStart, RequestBodyDone, RequestBodyNotEntirelyRead, RequestBodyDrainTimedOut, ResponseMinimumDataRateNotSatisfied, InvalidResponseHeaderRemoved, HeartbeatSlow.Microsoft.AspNetCore.Server.Kestrel.BadRequests
: ConnectionBadRequest, RequestProcessingError, RequestBodyMinimumDataRateNotSatisfied.Microsoft.AspNetCore.Server.Kestrel.Connections
: ConnectionAccepted, ConnectionStart, ConnectionStop, ConnectionPause, ConnectionResume, ConnectionKeepAlive, ConnectionRejected, ConnectionDisconnect, NotAllConnectionsClosedGracefully, NotAllConnectionsAborted,HeartbeatSlow, ApplicationAbortedConnection.Microsoft.AspNetCore.Server.Kestrel.Http2
: Http2ConnectionError, Http2ConnectionClosing, Http2ConnectionClosed, Http2StreamError, Http2StreamResetAbort, HPackDecodingError, HPackEncodingError, Http2FrameReceived, Http2FrameSending, Http2MaxConcurrentStreamsReached.Microsoft.AspNetCore.Server.Kestrel.Http3
: Http3ConnectionError, Http3ConnectionClosing, Http3ConnectionClosed, Http3StreamAbort, Http3FrameReceived, Http3FrameSending.Fixes #30301