-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blazor][Desktop] Mark packages as shipping #31035
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
src/Components/WebView/Platforms/WebView2/src/PublicAPI.Shipped.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
| ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copy from eng/PublicAPI.empty.txt instead of letting the analyzer create these files. We want the |
10 changes: 10 additions & 0 deletions
10
src/Components/WebView/Platforms/WebView2/src/PublicAPI.Unshipped.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
Microsoft.AspNetCore.Components.WebView.WebView2.IWebView2Wrapper | ||
Microsoft.AspNetCore.Components.WebView.WebView2.IWebView2Wrapper.AcceleratorKeyPressed -> System.EventHandler<Microsoft.Web.WebView2.Core.CoreWebView2AcceleratorKeyPressedEventArgs> | ||
Microsoft.AspNetCore.Components.WebView.WebView2.IWebView2Wrapper.CoreWebView2.get -> Microsoft.Web.WebView2.Core.CoreWebView2 | ||
Microsoft.AspNetCore.Components.WebView.WebView2.IWebView2Wrapper.EnsureCoreWebView2Async(Microsoft.Web.WebView2.Core.CoreWebView2Environment environment = null) -> System.Threading.Tasks.Task | ||
Microsoft.AspNetCore.Components.WebView.WebView2.IWebView2Wrapper.Source.get -> System.Uri | ||
Microsoft.AspNetCore.Components.WebView.WebView2.IWebView2Wrapper.Source.set -> void | ||
Microsoft.AspNetCore.Components.WebView.WebView2.WebView2WebViewManager | ||
Microsoft.AspNetCore.Components.WebView.WebView2.WebView2WebViewManager.WebView2WebViewManager(Microsoft.AspNetCore.Components.WebView.WebView2.IWebView2Wrapper webview, System.IServiceProvider services, Microsoft.AspNetCore.Components.Dispatcher dispatcher, Microsoft.Extensions.FileProviders.IFileProvider fileProvider, string hostPageRelativePath) -> void | ||
override Microsoft.AspNetCore.Components.WebView.WebView2.WebView2WebViewManager.NavigateCore(System.Uri absoluteUri) -> void | ||
override Microsoft.AspNetCore.Components.WebView.WebView2.WebView2WebViewManager.SendMessage(string message) -> void |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
src/Components/WebView/Platforms/WindowsForms/src/PublicAPI.Shipped.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
16 changes: 16 additions & 0 deletions
16
src/Components/WebView/Platforms/WindowsForms/src/PublicAPI.Unshipped.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.BlazorWebView() -> void | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.HostPage.get -> string | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.HostPage.set -> void | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.RootComponents.get -> System.Collections.ObjectModel.ObservableCollection<Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponent> | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.Services.get -> System.IServiceProvider | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.Services.set -> void | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.WebView.get -> Microsoft.Web.WebView2.WinForms.WebView2 | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponent | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponent.ComponentType.get -> System.Type | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponent.Parameters.get -> System.Collections.Generic.IDictionary<string, object> | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponent.RootComponent(string selector, System.Type componentType, System.Collections.Generic.IDictionary<string, object> parameters) -> void | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponent.Selector.get -> string | ||
Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponentCollectionExtensions | ||
static Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponentCollectionExtensions.Add<TComponent>(this System.Collections.ObjectModel.ObservableCollection<Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponent> components, string selector, System.Collections.Generic.IDictionary<string, object> parameters = null) -> void | ||
static Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponentCollectionExtensions.Remove(this System.Collections.ObjectModel.ObservableCollection<Microsoft.AspNetCore.Components.WebView.WindowsForms.RootComponent> components, string selector) -> void |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
20 changes: 20 additions & 0 deletions
20
src/Components/WebView/Platforms/Wpf/src/PublicAPI.Unshipped.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView | ||
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.BlazorWebView() -> void | ||
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.Dispose() -> void | ||
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.HostPage.get -> string | ||
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.HostPage.set -> void | ||
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.RootComponents.get -> System.Collections.ObjectModel.ObservableCollection<Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent> | ||
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.Services.get -> System.IServiceProvider | ||
Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.Services.set -> void | ||
Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent | ||
Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent.ComponentType.get -> System.Type | ||
Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent.ComponentType.set -> void | ||
Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent.Parameters.get -> System.Collections.Generic.IDictionary<string, object> | ||
Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent.Parameters.set -> void | ||
Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent.RootComponent() -> void | ||
Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent.Selector.get -> string | ||
Microsoft.AspNetCore.Components.WebView.Wpf.RootComponent.Selector.set -> void | ||
override Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.OnApplyTemplate() -> void | ||
static readonly Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.HostPageProperty -> System.Windows.DependencyProperty | ||
static readonly Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.RootComponentsProperty -> System.Windows.DependencyProperty | ||
static readonly Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView.ServicesProperty -> System.Windows.DependencyProperty |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given errors in CI build and much lower required version in global.json, these might need further changes to get working. If that's possible, please update https://github.com/dotnet/aspnetcore/blob/main/global.json#L22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't that update the required VS version for contributors? Do we want to bump that all the way up to 16.9? I think 16.6 would be recent enough to know about the new TFMs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it'll update what contributors need. Since 16.9 is the current public non-preview build of VS, I'm not positive that's a show-stopper.
But, if we decide not to jump to 16.9, I'd prefer we moved to 16.8 instead of 16.6 because it includes an
msbuild
supporting the new functions for the new TFMs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go for 16.8