Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error boundaries #30874

Merged
merged 55 commits into from
Apr 8, 2021
Merged

Error boundaries #30874

merged 55 commits into from
Apr 8, 2021

Commits on Apr 6, 2021

  1. Initial experiments

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    c0d3d59 View commit details
    Browse the repository at this point in the history

  2. Handle async event handler exceptions

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    952cac0 View commit details
    Browse the repository at this point in the history

  3. Test cases for lifecycle methods

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    4b12fc2 View commit details
    Browse the repository at this point in the history

  4. Handle SetParametersAsync exceptions

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    cc44e53 View commit details
    Browse the repository at this point in the history

  5. Handle IHandleAfterRender exceptions

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    5351089 View commit details
    Browse the repository at this point in the history

  6. Handle exceptions during rendering

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    4e7e3c5 View commit details
    Browse the repository at this point in the history

  7. Update notes about disposal

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    e6c1c1c View commit details
    Browse the repository at this point in the history

  8. Add note about Attach

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    0d6acd7 View commit details
    Browse the repository at this point in the history

  9. Handle exceptions during cascading value notifications

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2b35fe8 View commit details
    Browse the repository at this point in the history

  10. Update ErrorMaker.razor

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    42d1911 View commit details
    Browse the repository at this point in the history

  11. Add note about InvokeAsync

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2f68770 View commit details
    Browse the repository at this point in the history

  12. Clean up some notes

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    80ebf30 View commit details
    Browse the repository at this point in the history

  13. Clarify what we do if the IErrorBoundary component itself has an error

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    83de667 View commit details
    Browse the repository at this point in the history

  14. Force error boundaries to clear up their descendants on error, even b… 

    …efore we notify them. Also think about infinite error loops.
    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2a5a7d3 View commit details
    Browse the repository at this point in the history

  15. More thoughts on error loops

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    0cd43ff View commit details
    Browse the repository at this point in the history

  16. More thoughts

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    0a7a07f View commit details
    Browse the repository at this point in the history

  17. Clean up all the stuff about detailed errors and prerendering

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    8089c36 View commit details
    Browse the repository at this point in the history

  18. Add PrerenderingErrorBoundaryLogger

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    4514899 View commit details
    Browse the repository at this point in the history

  19. Let error boundaries catch their own inline errors

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2de4259 View commit details
    Browse the repository at this point in the history

  20. Redesign around ErrorBoundaryBase abstract base class.

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    415d8dd View commit details
    Browse the repository at this point in the history

  21. Define IErrorBoundary as an internal interface for clarity

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    9529163 View commit details
    Browse the repository at this point in the history

  22. Minor fix

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    bf04cf3 View commit details
    Browse the repository at this point in the history

  23. Handle logging errors

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    1db319e View commit details
    Browse the repository at this point in the history

  24. Make it possible to customize the UI via subclassing ErrorBoundary

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    0415115 View commit details
    Browse the repository at this point in the history

  25. Better default UI

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    a28c3ca View commit details
    Browse the repository at this point in the history

  26. Show you can subclass ErrorBoundary helpfully

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    275ae5a View commit details
    Browse the repository at this point in the history

  27. Rename AutoReset->AutoRecover

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    d319b9f View commit details
    Browse the repository at this point in the history

  28. Remove use of linq

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    15ab863 View commit details
    Browse the repository at this point in the history

  29. Tidy up comments

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    990128e View commit details
    Browse the repository at this point in the history

  30. Clean up and expand test cases

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    c9c7c6f View commit details
    Browse the repository at this point in the history

  31. CR: Add general-purpose OnErrorAsync to base class

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2f597f4 View commit details
    Browse the repository at this point in the history

  32. Remove AutoRecover feature because it can be done in user code now we… 

    … have Recover
    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    29e4760 View commit details
    Browse the repository at this point in the history

  33. Unit tests for component error boundary dispatch logic

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    08d4595 View commit details
    Browse the repository at this point in the history

  34. Make async flow clearer

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    7540d3a View commit details
    Browse the repository at this point in the history

  35. Fix unrelated test code badness

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    34e6519 View commit details
    Browse the repository at this point in the history

  36. Add E2E test UI

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    06da1ef View commit details
    Browse the repository at this point in the history

  37. Begin scripting E2E cases

    @SteveSandersonMS
    SteveSandersonMS committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    259f5d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Add some E2E tests for more difficult cases

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    63d950b View commit details
    Browse the repository at this point in the history

  2. Cope with receiving errors while already in an error state

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    ae4cdc4 View commit details
    Browse the repository at this point in the history

  3. Add failing unit test for errors after disposal

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    76f41fe View commit details
    Browse the repository at this point in the history

  4. Have renderer cope with errors after disposal

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    f5be9f1 View commit details
    Browse the repository at this point in the history

  5. Better handling of error loops

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    31def59 View commit details
    Browse the repository at this point in the history

  6. Fix description

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    015b4e2 View commit details
    Browse the repository at this point in the history

  7. Tidyup

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    832f72a View commit details
    Browse the repository at this point in the history

  8. Revert some unwanted changes

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    50c9ddb View commit details
    Browse the repository at this point in the history

  9. More cleanup

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    7df7d5a View commit details
    Browse the repository at this point in the history

  10. Add default error boundary content/style to project templates

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    0a61aaa View commit details
    Browse the repository at this point in the history

  11. Fix server E2E tests

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    4955cc3 View commit details
    Browse the repository at this point in the history

  12. Test for custom error boundary

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    92e506b View commit details
    Browse the repository at this point in the history

  13. Test for error ignorer

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    8f18c40 View commit details
    Browse the repository at this point in the history

  14. Test for inline errors

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    d151976 View commit details
    Browse the repository at this point in the history

  15. Test for errors after disposal

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    d85c8d2 View commit details
    Browse the repository at this point in the history

  16. Test for multiple concurrent errors

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    00e5e50 View commit details
    Browse the repository at this point in the history

  17. Stronger guidance to override OnErrorAsync

    @SteveSandersonMS
    SteveSandersonMS committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    5eae0b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. CR: Improve unit test

    @SteveSandersonMS
    SteveSandersonMS committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    9ace45d View commit details
    Browse the repository at this point in the history