Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IAssemblySymbol for tag helper discovery #30560

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Use IAssemblySymbol for tag helper discovery #30560

merged 1 commit into from
Mar 3, 2021

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Mar 2, 2021 •
edited
Loading

Instead of expecting a MetadataReference to resolve tag helpers from, we'll take an IAssemblySymbol because:

  • It plays nicer with the type that Rosyln exposes for the current compilation
  • Avoids us having to repeatedly convert a MetadataReference to an IAssemblySymbol in the tag helper providers

Also added a check for applicable tag helper providers to avoid looking for tag helpers in assemblies that are not the target assembly.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 2, 2021
@captainsafia captainsafia marked this pull request as ready for review March 2, 2021 22:03
@captainsafia captainsafia added the area-razor.compiler This issue is related to the Razor compiler (now external) label Mar 2, 2021
@captainsafia captainsafia merged commit 407b197 into main Mar 3, 2021
@captainsafia captainsafia deleted the safia/rsg-asm-symbol branch March 3, 2021 00:04
@marek-safar marek-safar mentioned this pull request Mar 3, 2021
Merged
@captainsafia captainsafia mentioned this pull request Apr 1, 2021
Merged
dougbu pushed a commit to dougbu/razor-compiler that referenced this pull request Nov 17, 2021
@captainsafia
Use IAssemblySymbol for tag helper discovery (dotnet/aspnetcore#30560)
dd844e4 
Commit migrated from dotnet/aspnetcore@407b197dd9f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@TanayParikh TanayParikh TanayParikh approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-razor.compiler This issue is related to the Razor compiler (now external)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@captainsafia @pranavkm @TanayParikh