2.1 SignalR npm readme #30271
Merged
2.1 SignalR npm readme #30271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradygaster
approved these changes
Feb 18, 2021
| @@ -1,5 +1,9 @@ | |||
| MsgPack support for SignalR for ASP.NET Core | |||
|
|
|||
| > :warning: This package will no longer be supported starting August 21, 2021. This package follows the [.NET Core 2.1 support lifecycle](https://dotnet.microsoft.com/platform/support/policy/dotnet-core) which is ending soon. Please transition to using [@microsoft/signalr-protocol-msgpack](https://www.npmjs.com/package/@microsoft/signalr-protocol-msgpack) as described below. | |||
There was a problem hiding this comment.
I appreciate the distant heads-up for potentially-impacted customers.
halter73
reviewed
Feb 18, 2021
| @@ -1,5 +1,9 @@ | |||
| MsgPack support for SignalR for ASP.NET Core | |||
|
|
|||
| > :warning: This package will no longer be supported starting August 21, 2021. This package follows the [.NET Core 2.1 support lifecycle](https://dotnet.microsoft.com/platform/support/policy/dotnet-core) which is ending soon. Please transition to using [@microsoft/signalr-protocol-msgpack](https://www.npmjs.com/package/@microsoft/signalr-protocol-msgpack) as described below. | |||
|
|
|||
| > Note: The JavaScript and TypeScript clients for SignalR for ASP.NET Core have been moved to [@microsoft/signalr-protocol-msgpack](https://www.npmjs.com/package/@microsoft/signalr-protocol-msgpack). If you are already using `@aspnet/signalr-protocol-msgpack` and are unsure when to move to `@microsoft/signalr-protocol-msgpack`, check the [Feature Distribution](https://docs.microsoft.com/en-us/aspnet/core/signalr/client-features) chart in the ASP.NET Core SignalR documentation. Newer client releases are compatible with older version of ASP.NET Core SignalR which means it is safe to upgrade the client before upgrading the server. | |||
There was a problem hiding this comment.
If you are already using
@aspnet/signalr-protocol-msgpackand are unsure when to move to@microsoft/signalr-protocol-msgpack, check the Feature Distribution chart in the ASP.NET Core SignalR documentation. Newer client releases are compatible with older version of ASP.NET Core SignalR which means it is safe to upgrade the client before upgrading the server.
Any particular reason you added this to the signalr-protocol-msgpack README but not the main signalr one?
There was a problem hiding this comment.
It already exists on the other one.
BrennanConroy
added
the
tell-mode
BrennanConroy
added
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
leecow
added
Servicing-approved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dougbu
pushed a commit
that referenced
this pull request
Apr 13, 2021
For some reason the code-merge job didn't run for this, despite it merging cleanly - CC @<Doug Bunting (AAPT)> @<Matt Mitchell> @<Brennan Conroy>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating README of SignalR npm packages to warn of upcoming end-of-support.
Customer Impact
None, no code changes.
Regression?
Risk
No code changes
Verification
Packaging changes reviewed?