!temporary! Increase dotnet-install logging #27972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changes may help figure out dotnet/core-eng#11424 - will likely go away in the next Arcade update PR - if not, we should revert this change after dotnet/core-eng#11424 is done for realz FYI @MattGal I didn't find a way to add similar logging in tools.sh. Tried - adding `chmod +x "$install_script"` in `GetDotNetInstallScript` - changing commands to `bash "verbose=true \"$install_script\" ..."` in `InstallDotNet` but that didn't get the `say_verbose` or `eval $invocation` bits in the script going.
ghost
added
the
area-infrastructure
wtgodbe
approved these changes
Nov 19, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
captainsafia
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @MattGal I didn't find a way to add similar logging in tools.sh. Tried
chmod +x "$install_script"inGetDotNetInstallScriptbash "verbose=true \"$install_script\" ..."inInstallDotNetbut that didn't get the
say_verboseoreval $invocationbits in the script going.