Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force invariant mode on #24163

Closed
wants to merge 1 commit into from
Closed

force invariant mode on #24163

wants to merge 1 commit into from

Conversation

lewing
Copy link
Member

@lewing lewing commented Jul 21, 2020

This will unblock the runtime sync

@lewing lewing requested review from SteveSandersonMS and a team as code owners July 21, 2020 17:52
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jul 21, 2020
@lewing
Copy link
Member Author

lewing commented Jul 21, 2020 •
edited
Loading

@pranavkm this is the quick way to unblock the runtime sync at #23978

@lewing lewing requested a review from pranavkm July 21, 2020 18:01
pranavkm
pranavkm reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in preview8?

@pranavkm
Copy link
Contributor

Let me update this as part of the merge PR. We'll need to regen the js files

@lewing
Copy link
Member Author

lewing commented Jul 21, 2020

If we add the full loading we can improve this but that can happen in a follow up

@pranavkm
Copy link
Contributor

I updated the merge PR: 66034f9. We can close this PR. Thanks @lewing

@pranavkm pranavkm closed this Jul 21, 2020
@lewing lewing mentioned this pull request Jul 21, 2020
Closed
@lewing lewing deleted the force-invariant branch January 5, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewing @pranavkm