-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Fix AzureAd options validation #23096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
02c2e91 to
822ec36
Compare
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
|
Hi, I'm still having this issue with 3.1.5 Throws My settings for ref: |
|
This fix has not been merged yet. It will be applied to the next 3.1 release (3.1.7). |
|
Ok thank you, is there a scheduled release date? |
|
It will be out in approximately a month. Generally we don't give out specific dates: see https://github.com/dotnet/core/blob/master/roadmap.md#upcoming-ship-dates. |
Addresses #20136
Description
Originally #9967 added options validation for AzureAd auth options, but it introduced a regression where it would throw for other cookie or jwt auth providers.
#13480 fixed this for jwt and cookies auth but the issue also affects OIDC auth. This PR applies the same fix to OIDC auth.
Customer Impact
Customers may not be able to use AzureAd auth combine with other kinds of auth in one app.
Regression?
Yes this is a regression in 3.1
Risk
Low, just adding a null check.