Make GetKnownHttpScheme "safe" #21204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
ghost
added
the
GrabYourPitchforks
approved these changes
Apr 25, 2020
| { | ||
| fixed (byte* data = span) | ||
| if (span.Length >= sizeof(ulong)) |
There was a problem hiding this comment.
The JIT isn't always smart enough to match this manual check to the call to BinaryPrimitives below, so it could end up duplicating the bounds check. Suggest using BinaryPrimitives.TryReadUInt64LittleEndian instead, which guarantees that the bounds check will be emitted a maximum of once.
There was a problem hiding this comment.
Raised issue for it dotnet/runtime#35348; will try the the Try version as you suggest
GrabYourPitchforks
approved these changes
Apr 25, 2020
halter73
approved these changes
Apr 28, 2020
|
Thanks! |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To @blowdart with ❤
Contributes to #4720