Skip to content

Endpoint-based concurrency limiter #20835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wu-yafeng wants to merge 4 commits into from
Closed

Endpoint-based concurrency limiter #20835

wu-yafeng wants to merge 4 commits into from

Conversation

@wu-yafeng
Copy link
Contributor

@wu-yafeng wu-yafeng commented Apr 15, 2020

I have another PR diffs #19324 PR has less breaking-changes and much more compatibility.I have added following features:

  • Add extension methods for IEndpointConventionBuilder.
  • Suppress concurrency limiter for specific endpoint.
  • Add endpoint-based queue policy
  • Add test case for middleware and type created in this PR.

Addresses #19823 (in this specific format)

@ghost ghost added the area-middleware label Apr 15, 2020
@wu-yafeng
Copy link
Contributor Author

wu-yafeng commented Apr 15, 2020

I‘m considering whether add analyzer to check ConcurrencyLimiterMiddleware is behind UseRouting(...) and before UseEndpoint(...)
I send another PR about Analyzer
#20837

@halter73 halter73 self-assigned this Apr 15, 2020
@wu-yafeng
Update comments and declare SupressQueuePolicyMetadata
630c61f 
- fix comment typo
- Add comments on `QueuePolicyAttribute` and `StackPolicyAttribute`
- rename `SupressQueuePolicyMetadata` to ``SupressQueuePolicyAttribute`
- declare `SupressQueuePolicyAttribute` as public
- fix typo comments on `ConcurrencyLimiterEndpointConventionBuilderExtensions.cs`
@wu-yafeng
Apply attribute to SuppressQueuePolicyAttribute and StackPolicyAttribute
bc83741
@halter73 halter73 mentioned this pull request Aug 3, 2020
Closed
@BrennanConroy BrennanConroy added the community-contribution Indicates that the PR has been added by a community member label Jan 8, 2021
Base automatically changed from master to main January 22, 2021 01:32
@Tratcher Tratcher mentioned this pull request Feb 11, 2021
Closed
@halter73
Copy link
Member

halter73 commented Mar 3, 2021

Thanks for the contribution @wu-yafeng and sorry for not getting back to you on this sooner. It doesn't look like we're going to be investing much more in ConcurrencyLimiterMiddleware and instead will be investigating a broader feature around request throttling: #29933. Because of this, I don't think it's worth adding new features to this API.

@halter73 halter73 closed this Mar 3, 2021
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@halter73 halter73

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wu-yafeng @halter73 @Pilchie @BrennanConroy @amcasey