Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 14, 2020

Resolves #18792. We stopped publishing checksums some time in the 2.1 time frame - this PR turns that feature back on. Validated with https://dev.azure.com/dnceng/internal/_build/results?buildId=520228 (though that build incorrectly prefixed RelativeBlobPath with Dotnet - I've fixed that up in this PR). Still a bit of cleanup to do, but it works as intended.

@dougbu @JunTaoLuo PTAL

CC @Pilchie @mthalman

@wtgodbe wtgodbe added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Feb 14, 2020
@wtgodbe wtgodbe added this to the 3.1.3 milestone Feb 14, 2020
@wtgodbe wtgodbe requested a review from dougbu as a code owner February 14, 2020 00:54
@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 14, 2020

Will rebase once #19036 is in

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need checksums for Linux and macOS installers & bundles?

@dougbu
Copy link
Contributor

dougbu commented Feb 14, 2020

Please do a trial run on internal queues. Big piece of this won't work except in a "real" build.

@Pilchie
Copy link
Member

Pilchie commented Feb 14, 2020

This looks good to me. We need something for 2.1.x as well right?

@dougbu
Copy link
Contributor

dougbu commented Feb 14, 2020

@wtgodbe any internal build or answers to questions above will be much appreciated 😈

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 14, 2020

Don't we need checksums for Linux and macOS installers & bundles?

That wasn't an original requirement, just the runtime archives & Windows installer executables - #18792 (comment). I did a catch-all in the Windows installer folder because it seemed cleaner than picking-and-choosing the specific output Items we wanted, and more SHA512 files doesn't hurt (e.g. runtime & core-sdk do checksums for their installers). That being said, there's no good reason not to do checksums for those bundles, so I can add them.

Please do a trial run on internal queues. Big piece of this won't work except in a "real" build.

I linked the validation build in the PR description: https://dev.azure.com/dnceng/internal/_build/results?buildId=520228. I'll run another one after applying your feedback.

This looks good to me. We need something for 2.1.x as well right?

Yep, I'll look into what's needed for that tomorrow. It may be pretty different from what I'm doing here

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 14, 2020

New build: https://dev.azure.com/dnceng/internal/_build/results?buildId=521702

I realized this does do checksums for the OSX/Linux bundles (the tar.gz archives) - it just doesn't do so for the debs/rpms

@dougbu
Copy link
Contributor

dougbu commented Feb 14, 2020

it just doesn't do so for the debs/rpms

As long as those aren't needed, sounds good. /cc @mthalman @MichaelSimons

@mthalman
Copy link
Member

it just doesn't do so for the debs/rpms

As long as those aren't needed, sounds good. /cc @mthalman Matt Thalman FTE @MichaelSimons Michael Simons (.NET) FTE

Yes, that's fine.

@dougbu
Copy link
Contributor

dougbu commented Feb 14, 2020

@wtgodbe please look into the incredibly high number of warnings in your internal build. What gives?

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 14, 2020

@dougbu those are mostly the Nuget warnings about stable packages w/ prerelease dependencies. They appear to have gone away in the new build, which is rebased on top of your change that fixed that problem.

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 14, 2020

New internal build looks good, and I've confirmed everything got published to dotnetclichecksums:
Checksums

@dougbu @mthalman any last concerns?

@dougbu
Copy link
Contributor

dougbu commented Feb 14, 2020

No issues except for the new conflict in Publishing.props

@wtgodbe wtgodbe merged commit bdb6a38 into release/3.1 Feb 14, 2020
@wtgodbe wtgodbe deleted the wtgodbe/Checksum3x branch February 14, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants