Skip to content

Build 3.0 site extension #17758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrennanConroy wants to merge 2 commits into from
Closed

Build 3.0 site extension #17758

BrennanConroy wants to merge 2 commits into from

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Dec 10, 2019

Start of #15381

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Jan 10, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 10, 2020

Azure Pipelines successfully started running 2 pipeline(s).

bradygaster
bradygaster reviewed Jan 14, 2020
View reviewed changes
src/SiteExtensions/Sdk/SiteExtension.targets
PackagePath="$(_BasePackagePath)\shared\Microsoft.AspNetCore.App\$(MicrosoftAspNetCoreAppPackageVersion)\"
PackagePath="$(_BasePackagePath)\shared\Microsoft.AspNetCore.App\$(AspNetCoreMajorMinorVersion).0\"
/>
<!-- Always use Major.Minor.0 so that if we have to produce a new SiteExtension during a patch build it will still work for non-patch runtimes. i.e. 3.0.0 dotnet will search for 3.0.0 and below and wouldn't find a 3.0.1 folder path -->
Copy link
Member

@bradygaster bradygaster Jan 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkotalik
Copy link
Contributor

jkotalik commented Jan 15, 2020

@BrennanConroy are you able to get to this fairly soon? Personally I'd prefer to get this into the next patch available.

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Jan 15, 2020

As far as I'm aware this is building correctly and effectively good to go.

We need to decide whether we are building it for 3.0 or skipping. And then figure out how to get the 3.0 bits into a 3.1 build.

@analogrelay
Copy link
Contributor

analogrelay commented Jan 15, 2020

We need to decide whether we are building it for 3.0 or skipping. And then figure out how to get the 3.0 bits into a 3.1 build.

The Site Extension itself is "versionless" (i.e. users should always install the latest). I'd like us to build one out of release/3.1 that includes bits for 2.1, 3.0 and 3.1 and ship that. Then we can revisit in 5.0 and hopefully not have to ship one there :).

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Jan 15, 2020

I'd like us to build one out of release/3.1 that includes bits for 2.1, 3.0 and 3.1 and ship that

Yeah, we need to build and "release" the 3.0 one first. Then we can reference the 3.0 one in a 3.1 build.

@analogrelay
Copy link
Contributor

analogrelay commented Jan 15, 2020

Got it. Let's get this PR ready to take in March.

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Jan 24, 2020

Closing in favor of #18568

@BrennanConroy BrennanConroy deleted the brecon/siteEx branch January 24, 2020 21:26
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradygaster bradygaster bradygaster approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@analogrelay analogrelay Awaiting requested review from analogrelay

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@BrennanConroy BrennanConroy

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BrennanConroy @jkotalik @analogrelay @bradygaster @Pilchie @amcasey