Skip to content

[master] Update SDK #16753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrennanConroy merged 2 commits into from
Nov 1, 2019
Merged

[master] Update SDK #16753

BrennanConroy merged 2 commits into from
Nov 1, 2019

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Nov 1, 2019 •
edited
Loading

This fixes the

The "PushToAzureDevOpsArtifacts" task could not be loaded from the assembly /Users/runner/runners/2.159.2/work/1/s/.packages/microsoft.dotnet.build.tasks.feed/5.0.0-beta.19529.3/build/../tools/netcoreapp2.1/Microsoft.DotNet.Build.Tasks.Feed.dll.
Could not load file or assembly 'NuGet.Common, Version=5.3.0.4, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Could not find or load a specific file. (0x80131621) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

error which occurred because when we updated arcade we got a newer version of NuGet.Packaging. This version was newer than the version in the SDK which causes issues. We need to either be the same version or a lower version.

So updating the SDK puts us on the same version for now. This should not be a common occurrence.

@BrennanConroy BrennanConroy added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 1, 2019
@BrennanConroy BrennanConroy requested a review from a team November 1, 2019 20:15
@BrennanConroy BrennanConroy merged commit bd917f6 into master Nov 1, 2019
@BrennanConroy BrennanConroy deleted the brecon/nuget branch November 1, 2019 21:43
@BrennanConroy BrennanConroy mentioned this pull request Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrennanConroy @wtgodbe