Skip to content

Update to newer SDK #14168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wtgodbe wants to merge 9 commits into from
Closed

Update to newer SDK #14168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
72d44b4
Update to newer SDK
wtgodbe Sep 19, 2019
2f643cd
Add NoWarns
wtgodbe Sep 19, 2019
42b6004
Revert changes to templatePackageInstaller.cs
wtgodbe Sep 19, 2019
c7acbaa
Add vNext SDK Workaround
wtgodbe Sep 20, 2019
351419b
Test - remove KnownAppHostPack workaround
wtgodbe Sep 20, 2019
f6e5792
Undo last change
wtgodbe Sep 20, 2019
d881b81
Try workaround in d.b.t
wtgodbe Sep 20, 2019
be42a1f
Test - remove KnownAppHostPack
wtgodbe Sep 20, 2019
7e5b057
Short circuit when ItemGroup is epty
wtgodbe Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"sdk": {
"version": "5.0.100-alpha1-013788"
"version": "5.0.100-alpha1-014696"
},
"tools": {
"dotnet": "5.0.100-alpha1-013788",
"dotnet": "5.0.100-alpha1-014696",
"runtimes": {
"dotnet/x64": [
"$(MicrosoftNETCoreAppRuntimeVersion)"
Expand Down
4 changes: 2 additions & 2 deletions src/ProjectTemplates/test/Helpers/TemplatePackageInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ private static async Task InstallTemplatePackages(ITestOutputHelper output)

/*
* The templates are indexed by path, for example:
&USERPROFILE%\.templateengine\dotnetcli\v5.0.100-alpha1-013788\packages\nunit3.dotnetnew.template.1.6.1.nupkg
&USERPROFILE%\.templateengine\dotnetcli\v5.0.100-alpha1-014696\packages\nunit3.dotnetnew.template.1.6.1.nupkg
Templates:
NUnit 3 Test Project (nunit) C#
NUnit 3 Test Item (nunit-test) C#
Expand All @@ -99,7 +99,7 @@ NUnit 3 Test Item (nunit-test) F#
NUnit 3 Test Project (nunit) VB
NUnit 3 Test Item (nunit-test) VB
Uninstall Command:
dotnet new -u &USERPROFILE%\.templateengine\dotnetcli\v5.0.100-alpha1-013788\packages\nunit3.dotnetnew.template.1.6.1.nupkg
dotnet new -u &USERPROFILE%\.templateengine\dotnetcli\v5.0.100-alpha1-014696\packages\nunit3.dotnetnew.template.1.6.1.nupkg

* We don't want to construct this path so we'll rely on dotnet new --uninstall --help to construct the uninstall command.
*/
Expand Down