Update Microsoft.Data.SqlClient version #13530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-infrastructure
JunTaoLuo
added
the
ask-mode
dougbu
approved these changes
Aug 29, 2019
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Looks good once QB-approved
Contributor
Author
|
Hmm looks like there's a new binary Microsoft.Identity.Client.dll that's now added to the dotnet-sql-cache tool package. It does look signed so maybe it's fine to ignore during signing? I'm looking why this is now being added to the tool package though. The version of that dependency should not have changed when updating Microsoft.Data.SqlClient. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12957.
Verifying locally.Verified locally by running tool directly to create new tables on a local db.